Fix text copying in Chrome

[athomschke]

Sometimes the whole world crashes (e.g. if text from other websides is copied) and sometimes it shows the following stack trace:

Error in handleEvent when calling <lively.morphic.Text#48D53...>>>onPaste: TypeError?: Object #<Comment> has no method 'getAttribute' TypeError?: Object #<Comment> has no method 'getAttribute'

at Function.extractStylesAndApplyToRichText ( http://lively-kernel.org/repository/webwerkstatt/core/generated/combinedModules.js?5c933f641c8f5ad944312307a171f253:16061:26) at Function.pastedHTMLToRichText ( http://lively-kernel.org/repository/webwerkstatt/core/generated/combinedModules.js?5c933f641c8f5ad944312307a171f253:16040:14) at Text.onPaste ( http://lively-kernel.org/repository/webwerkstatt/core/generated/combinedModules.js?5c933f641c8f5ad944312307a171f253:14136:50) at EventHandler?.handleEvent ( http://lively-kernel.org/repository/webwerkstatt/core/generated/combinedModules.js?5c933f641c8f5ad944312307a171f253:20005:63) at HTMLDivElement.bound ( http://lively-kernel.org/repository/webwerkstatt/core/lively/bootstrap.js:814:37)

Also, copying screws the indetation.

[fbo]

Do you have a sample page at hand that lets us reproduce the error?

[sstamm]

 http://lively-kernel.org/repository/webwerkstatt/issues/120120_FixTextCopyingInChrome.xhtml

Case 1: open any page, open a workspace, write "some text", copy it (without any linebreaks), paste it.

Expected: "some text" is pasted in the same line Result is: "some text" is pasted in a new line

Case 2: copy "some text" with newline, paste it. (in the new line must not be any character)

Expected: "some text" is pasted, the cursor is in a new line Result is: world crashes

[jenslincke]

pasting HTML BR -> exception testPasteString('a<br>b')

pasting XHTML BR -> no exception testPasteString('a<br/>b')

[athomschke]

fixed in revision 130527

[sstamm]

could not verify fix.

updated issue page, case 3: copy "some text" with newline, paste it. Result is: sometext is pasted with two new lines

[athomschke]

fixed again in revision 130596

[mzimmerm]

This is still happening on Chrome (both stable 16 and dev 18) on Linux. It can be duplicated on pretty much any text copy/paste. A one-word "bombs" highlight followed by Ctrl-C then Ctrl-V produces:

PASTE ERROR: Error: INVALID_STATE_ERR: DOM Exception 11

could not paste: <meta http-equiv="content-type" content="text/html; charset=utf-8"><span style="color: rgb(0, 0, 0); font-family: Arial, sans-serif; font-size: 19px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: pre-wrap; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); display: inline !important; float: none; ">bombs</span>

please report problem on:  http://lively-kernel.org/trac

[huberthesse]

I can reproduce mzimmerm's last error message.

[huberthesse]

Another error dump:

PASTE ERROR: Error: INVALID_STATE_ERR: DOM Exception 11

could not paste: <span> var t1 = $morph('Touch1'), t2 = $morph('Touch2'), tmid = $morph('TouchMid?');

if(t1 && t2 && tmid){

t1.setPosition(touch1); t2.setPosition(touch2); tmid.setPosition(touch1.midPt(touch2))

}</span>

please report problem on:  http://lively-kernel.org/trac

[athomschke]

fixed in revision 131556 (Linux copy paste error) cause: meta tag could not be parsed

[mzimmerm]

I can confirm this is now fixed in Chrome Linux & still works on Chrome Windows. Firefox also keeps working.

[mzimmerm]

Actually - Chrome on Linux still has one issue : So inside lively, copy-paste works.

But , go to google, search for "searchin google", click the search button, and then Ctrl-C the URL address from browser. Paste into a text box in lively:

PASTE ERROR: Error: INVALID_STATE_ERR: DOM Exception 11

could not paste: <meta http-equiv="content-type" content="text/html; charset=utf-8"><a href=" http://www.google.ca/webhp?sourceid=chrome-instant&ix=sea&ie=UTF-8&ion=1#sclient=psy-ab&hl=en&site=webhp&source=hp&q=searchin%20google&pbx=1&oq=&aq=&aqi=&aql=&gs_sm=&gs_upl=&fp=23d5895b48c2c061&ix=sea&ion=1&ix=sea&ion=1&bav=on.2,or.r_gc.r_pw.r_cp.,cf.osb&fp=23d5895b48c2c061&biw=1333&bih=706&ix=sea&ion=1"> http://www.google.ca/webhp?sourceid=chrome-instant&amp;ix=sea&amp;ie=UTF-8&amp;ion=1#sclient=psy-ab&amp;hl=en&amp;site=webhp&amp;source=hp&amp;q=searchin%20google&amp;pbx=1&amp;oq=&amp;aq=&amp;aqi=&amp;aql=&amp;gs_sm=&amp;gs_upl=&amp;fp=23d5895b48c2c061&amp;ix=sea&amp;ion=1&amp;ix=sea&amp;ion=1&amp;bav=on.2,or.r_gc.r_pw.r_cp.,cf.osb&amp;fp=23d5895b48c2c061&amp;biw=1333&amp;bih=706&amp;ix=sea&amp;ion=1</a>

please report problem on:  http://lively-kernel.org/trac

[mzimmerm]

Actually - same problem exists in Windows as well. Guessing the parsing of that link. Hope it's ok to reopen, although this makes the bug a lower priority then blocker imo.

(BTW thanks for fixing the main issue, I can now use faster Chrome again)

[jenslincke]

thanks for reporting, you can reopen this bug any time you get the error message. I fixed it in such a way, that it won't break, e.g. the link contained an & which I replace with "&amp;", we do not treat the link correctly any way... that should be another ticket

[bsiegmund]

When copying '<', '>' or '&', they are converted to html entities '&lt;', '&gt;' or '&amp;'

[bsiegmund]

sry, my bad, wrong ticket

[mzimmerm]

I see how you fixed it. No need to reopen this I am happy about the copy - paste functionality. - and I see someone created http://www.lively-kernel.org/trac/ticket/293 (Pasting HyperText?) which I suppose is a generic approach to hypertext pasting from inside and outside lively.

Thanks for those quick text fixes!